Skip to content

Conversation

datamweb
Copy link
Collaborator

@datamweb datamweb commented Sep 20, 2024

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb
Copy link
Collaborator Author

It seems that the failure of the tests is not related to this PR.

   This program has encountered a fatal error and cannot continue running at Fri Sep 20 20:03:32 2024
   The following diagnostic information is available:
P:\MyGitHubWork\shield>php vendor/bin/phpunit
PHPUnit 9.6.21 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.0RC6 with Xdebug 3.3.0alpha3
Configuration: P:\MyGitHubWork\shield\phpunit.xml.dist
Random Seed:   1726862948

...............................................................  63 / 526 ( 11%)
............................................................... 126 / 526 ( 23%)
............................................................... 189 / 526 ( 35%)
............................................................... 252 / 526 ( 47%)
............................................................... 315 / 526 ( 59%)
............................................................... 378 / 526 ( 71%)
............................................................... 441 / 526 ( 83%)
............................................................... 504 / 526 ( 95%)
......................                                          526 / 526 (100%)

Nexus\PHPUnit\Extension\Tachycardia identified these 30 slow tests:
+---------------------------------------------------------------------------------+---------------+-------------+
| Test Case                                                                       | Time Consumed | Time Limit  |
+---------------------------------------------------------------------------------+---------------+-------------+
| Tests\\Controllers\\RegisterTest::testRegisteredButNotActivatedAndLogin         | 00:00:01.05   | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisterRedirectsToActionIfDefined        | 00:00:01.02   | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisteredAndSessionExpiredAndLogin       | 00:00:01.02   | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisteredButNotActivatedAndRegisterAgain | 00:00:01.00   | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisterActionSuccess                     | 00:00:01.00   | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisterActionSuccessWithNoEmailLogin     | 00:00:00.99   | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisterActionWithBadEmailValue           | 00:00:00.97   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testAddgroupCancel                                   | 00:00:00.97   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testPassword                                         | 00:00:00.95   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testDeactivate                                       | 00:00:00.94   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testChangeemail                                      | 00:00:00.93   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testAddgroup                                         | 00:00:00.93   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testCreateWithInvalidGroup                           | 00:00:00.92   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testPasswordWithoutOptionsAndSpecifyEmail            | 00:00:00.92   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testDeleteUserNotExist                               | 00:00:00.92   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testRemovegroup                                      | 00:00:00.92   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testListByEmail                                      | 00:00:00.92   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testChangeemailInvalidEmail                          | 00:00:00.91   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testActivate                                         | 00:00:00.91   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testChangename                                       | 00:00:00.91   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testCreatePasswordNotMatch                           | 00:00:00.91   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testDeleteById                                       | 00:00:00.91   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testChangenameInvalidName                            | 00:00:00.91   | 00:00:00.50 |
| Tests\\Unit\\PasswordsTest::testHash                                            | 00:00:00.91   | 00:00:00.50 |
| Tests\\Unit\\DictionaryValidatorTest::testCheckTrueOnNotFound                   | 00:00:00.89   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testRemovegroupCancel                                | 00:00:00.89   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testCreateWithGroupBeta                              | 00:00:00.89   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testList                                             | 00:00:00.88   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testCreate                                           | 00:00:00.86   | 00:00:00.50 |
| Tests\\Commands\\UserTest::testNoAction                                         | 00:00:00.83   | 00:00:00.50 |
+---------------------------------------------------------------------------------+---------------+-------------+
...and 14 more tests hidden from view.


Time: 01:19.552, Memory: 54.00 MB

OK (526 tests, 1118 assertions)

@datamweb datamweb merged commit f5bb892 into codeigniter4:develop Oct 3, 2024
18 of 32 checks passed
@datamweb datamweb deleted the add-psalm-file-for-cs branch October 3, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants